Scripts: Updates to scripts using sof-testbench4 simulation by singalsu · Pull Request #10545 · thesofproject/sof

singalsu · 2026-02-12T16:45:06Z

No description provided.

This change adds option --mem_model to xt-run command. It should give better realistic MCPS and cycles numbers for processing with the more accurate memory model. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

Copilot

Pull request overview

Updates sof-testbench4-related configuration and scripts to use a new DRC default preset and to expand profiling/testing coverage for additional components.

Changes:

Add a new DRC preset selector (default_speaker_mic) for bench capture/playback control configs and set it as the default in bench target CMake parameters.
Extend sof-testbench helper/build scripts with separate output-rate option handling and updated xt-run invocation flags.
Expand profiling and host test coverage to include additional components/modules.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tools/topology/topology2/include/bench/drc_controls_playback.conf	Adds a new DRC preset key for playback that maps to a speaker-oriented DRC config.
tools/topology/topology2/include/bench/drc_controls_capture.conf	Adds a new DRC preset key for capture that maps to a DMIC-oriented DRC config.
tools/topology/topology2/development/tplg-targets-bench.cmake	Switches bench default DRC params to the new `default_speaker_mic` selector.
scripts/sof-testbench-helper.sh	Adds `-R` handling and updates xt-run calls to include `--mem_model`.
scripts/sof-testbench-build-profile.sh	Splits module profiling lists and adds an extra profiling loop at 44.1k.
scripts/host-testbench.sh	Adds host testbench coverage for additional components.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tools/topology/topology2/development/tplg-targets-bench.cmake

Copilot · 2026-02-12T16:54:18Z

scripts/sof-testbench-build-profile.sh

 }

-MODULES_S32="asrc dcblock drc drc_multiband eqfir eqiir gain src tdfb"
+MODULES_S32_44K_48K="asrc src"


The variable name MODULES_S32_44K_48K implies these modules should be profiled at both 44.1k and 48k, but the loop only runs at 44100. Either rename the variable to match the implemented behavior (e.g., MODULES_S32_44K) or add a second run at 48000 to align with the name.

Copilot · 2026-02-12T16:54:18Z

scripts/sof-testbench-build-profile.sh

+for mod in $MODULES_S32_44K_48K
+do
+    echo "Profiling $mod ..."
+    $HELPER -r 44100 -x -m "$mod" \
+	    -p "$PDIR/profile-$PLATFORM-$mod.txt" > "$PDIR/log-$PLATFORM-$mod.txt"
+done


The variable name MODULES_S32_44K_48K implies these modules should be profiled at both 44.1k and 48k, but the loop only runs at 44100. Either rename the variable to match the implemented behavior (e.g., MODULES_S32_44K) or add a second run at 48000 to align with the name.

The input is 44.1 kHz and output is 48 kHz, so the test really runs at both rates.

good idea to add 44100 testing! We should maybe add such a test to PR CI too?..

It would be quite simple with a scripts/hosts-testbench.sh change.

scripts/sof-testbench-build-profile.sh

Copilot · 2026-02-12T16:54:18Z

scripts/sof-testbench-helper.sh

 VALGRIND=

-while getopts "b:c:hi:km:n:o:p:r:t:vx" opt; do
+while getopts "b:c:hi:km:n:o:p:r:R:t:vx" opt; do


A new -R option is introduced for output rate. Make sure the script’s help/usage text documents -R (and clarifies the distinction between -r input rate and -R output rate), otherwise users will not discover the new option from -h.

Yep, makes sense

Copilot · 2026-02-12T16:54:18Z

scripts/sof-testbench-helper.sh

        r)
 	    RATE_IN=${OPTARG}
+	    ;;
+        R)
 	    RATE_OUT=${OPTARG}
 	    ;;


A new -R option is introduced for output rate. Make sure the script’s help/usage text documents -R (and clarifies the distinction between -r input rate and -R output rate), otherwise users will not discover the new option from -h.

Copilot · 2026-02-12T16:54:19Z

scripts/sof-testbench-helper.sh

+	"$XTENSA_PATH"/xt-run --mem_model --profile="$PROFILEOUT" "$XTB4" $OPTS 2> "$TRACEFILE"
 	"$XTENSA_PATH"/xt-gprof "$XTB4" "$PROFILEOUT" > "$PROFILETXT"
    else
-	"$XTENSA_PATH"/xt-run "$XTB4" $OPTS 2> "$TRACEFILE"
+	"$XTENSA_PATH"/xt-run --mem_model "$XTB4" $OPTS 2> "$TRACEFILE"


--mem_model is now always passed to xt-run. If this script is expected to work across multiple Xtensa toolchain versions/environments, consider making this flag configurable (env var or script option) or add a small compatibility fallback when xt-run doesn’t recognize --mem_model (e.g., retry without the flag).

I'm not aware of a toolchain version without support for --mem_model.

This change does input rate changing with -r and to change both input and output rate, need to specify both -r and -R. With this change it's easy to test e.g. performance of 44100 to 48000 SRC with "-r 44100". Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

The SRC perf numbers are unrealistic low when tested with 48 kHz input. This change adds a test list for components with 44.1 kHz input and 48 kHz output. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This patch adds dolby-dax (mock), level_multiplier, micsel, sound_dose, stft_process and template_comp into profiled list. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This patch changes the blobs in playback and capture DRC test topologies to speaker and microphone defaults. It improves test coverage of DRC since the previously used "enabled" blob does very little processing for the audio signal. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This patch adds Dolby DAX (stub version), level_multiplier, micsel, sound_dose to scripts/host-testbench.sh. Running this quick test for sane output and memory violations with Valgrind helps to avoid regressions in the modules. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

Scripts: sof-testbench-helper: Use memory model for xt-run

d7879ae

This change adds option --mem_model to xt-run command. It should give better realistic MCPS and cycles numbers for processing with the more accurate memory model. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

singalsu marked this pull request as ready for review February 12, 2026 16:52

singalsu requested review from dbaluta, jsarha, kv2019i, lbetlej, lgirdwood, mmaka1, plbossart and ranj063 as code owners February 12, 2026 16:52

Copilot AI review requested due to automatic review settings February 12, 2026 16:52

Copilot AI reviewed Feb 12, 2026

View reviewed changes

singalsu added 5 commits February 13, 2026 10:46

Scripts: sof-testbench-build-profile: Add more components to profile

074e730

This patch adds dolby-dax (mock), level_multiplier, micsel, sound_dose, stft_process and template_comp into profiled list. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

singalsu force-pushed the scripts_update_testbench_profiler_run branch from 36c1019 to 09315da Compare February 13, 2026 08:48

kv2019i approved these changes Feb 24, 2026

View reviewed changes

lgirdwood approved these changes Feb 24, 2026

View reviewed changes

lgirdwood merged commit 027a13f into thesofproject:main Feb 24, 2026
49 of 52 checks passed

Comments

Conversation

singalsu commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

singalsu Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

lyakh Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

singalsu Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

singalsu Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

singalsu Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants